fix: remove short flag -j for json and return response to global json handler #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Git2Gus App is installed but the |
RasPhilCo
requested review from
RodEsp and
saracope
and removed request for
RodEsp
saracope
approved these changes
Jul 19, 2022
RasPhilCo
changed the title
RodEsp
suggested changes
Jul 20, 2022
RodEsp
approved these changes
Jul 20, 2022
Contributor
RodEsp
left a comment
RodEsp
left a comment
There was a problem hiding this comment.
This all looks good to me but I'm not setup to run commands against an org with functions enabled so I can't QA. Trusting you guys are 😄
Comment on lines
-67
to
-69
| if (!flags.json) { | ||
| cli.action.start(`Creating compute environment for org ID ${orgId}`); | ||
| } |
Contributor
There was a problem hiding this comment.
Did you QA this?
I'm not sure that cli.action.start() has the same --json checks that this.log() does.
Contributor
Author
There was a problem hiding this comment.
Actions go out on stderr, so this shouldn't matter.
Contributor
Author
There was a problem hiding this comment.
"He says 99% sure."
Contributor
Author
There was a problem hiding this comment.
https://github.com/oclif/cli-ux/blob/21e8525497e6b4e9b4fa6cc1e2006bae2ff402eb/src/action/base.ts#L29
$ ./bin/dev logout functions --json 1>/dev/null
Logging out of Salesforce Functions... done
$ ./bin/dev logout functions --json 2>/dev/null
{
"status": 0,
"result": "Logged out",
"warnings": []
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove -j from json flag and moves --json into global flags in help
Use this.warn to add warnings to json object
Return result from run for json handler & schema check
What issues does this PR fix or reference?
@W-00000000@